rpuch commented on code in PR #2450:
URL: https://github.com/apache/ignite-3/pull/2450#discussion_r1307559792
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/RaftGroupOptions.java:
##########
@@ -42,6 +43,9 @@ public class RaftGroupOptions {
/** Configuration of own striped disruptor for FSMCaller service of raft
node, {@code null} means use shared disruptor. */
private @Nullable RaftNodeDisruptorConfiguration
ownFsmCallerExecutorDisruptorConfig;
+ /** Marshaller to marshall/unmarshall commands. */
+ private @Nullable Marshaller commandsMarshaller;
Review Comment:
For partitions, we need to quickly extract requiredCatalogVersion from
command's serialized representation without parsing the whole command. To do
so, I tweaked the marshaller used for partitions, but it adds one byte to each
command that does not have that requiredCatalogVersion. If we use same
marshaller for other (non-partition) groups, we unnecessarily increase their
(serialized) sizes as well. Hence the necessity to have ability to supply a
different marshaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
