[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2518: IGNITE-19768 Use schema sync instead of explicit config check

[via GitHub]

AMashenkov commented on code in PR #2518:
URL: https://github.com/apache/ignite-3/pull/2518#discussion_r1312761757


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItDataSchemaSyncTest.java:
##########
@@ -167,9 +170,11 @@ public void checkSchemasCorrectUpdate() throws Exception {
         table = (TableImpl) ignite2.tables().table(TABLE_NAME);
 
         TableImpl table0 = table;
-        assertTrue(waitForCondition(() -> 
table0.schemaView().schema().version() == 2, 5_000));
+        assertTrue(waitForCondition(tableSchemaVersionEqPredicate(table0, 2), 
5_000));
 
-        table = (TableImpl) ignite1.tables().table(TABLE_NAME);
+        table = ((TableManager) ignite1.tables()).getTable(table.tableId());
+
+        assertFalse(waitForCondition(tableSchemaVersionEqPredicate(table, 2), 
5_000));

Review Comment:
   What do you mean?
   Test is already fixed the way you refers to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org