AMashenkov commented on code in PR #2518:
URL: https://github.com/apache/ignite-3/pull/2518#discussion_r1312813113
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1864,29 +1850,19 @@ private CompletableFuture<List<Table>>
tablesAsyncInternal() {
}
/**
- * Collects a list of direct table ids.
+ * Return actual table id by given name or {@code null} if table doesn't
exist.
*
- * @return A list of direct table ids.
+ * @param tableName Table name.
+ * @return Table id or {@code null} if not found.
*/
- private List<Integer> directTableIds() {
- return configuredTablesCache.configuredTableIds();
- }
-
- /**
- * Gets direct id of table with {@code tblName}.
- *
- * @param tblName Name of the table.
- * @return Direct id of the table, or {@code null} if the table with the
{@code tblName} has not been found.
- */
- @Nullable
- private Integer directTableId(String tblName) {
+ private @Nullable Integer tableNameToId(String tableName) {
Review Comment:
Why should there be a synchronization?
This method is used after sync, to resolve table name to id. We go to the
config, becase we need an id from config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
