AMashenkov commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1315005734


##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -245,37 +222,36 @@ public class TableManagerTest extends IgniteAbstractTest {
     /** Hybrid clock. */
     private final HybridClock clock = new HybridClockImpl();
 
+    /** Catalog vault. */
+    private VaultManager catalogVault;

Review Comment:
   I think you can pass a CatalogEvent directly to TableManager listeners.
   
   And I don't understand the purpose of `mockManagersAndCreateTableWithDelay` 
test.
   If the test check interactions between CatalogManager and TableManager, then 
it should be proper integration test.
   If it just a unit, that checks guarantee the table will be properly 
initialized, then passing an event is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to