[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2500: IGNITE-19499 TableManager should listen CatalogService events instead of configuration

[via GitHub]

tkalkirill commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1319408323


##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/configuration/SchemaDistributedConfigurationModuleTest.java:
##########
@@ -45,24 +41,22 @@ void typeIsDistributed() {
 
     @Test
     void providesTableValidator() {
-        assertThat(module.validators(), 
hasItem(instanceOf(TableValidatorImpl.class)));
+        assertThat(module.validators(), empty());
     }
 
     @Test
     void providesColumnTypeValidator() {
-        assertThat(module.validators(), 
hasItem(instanceOf(ColumnTypeValidatorImpl.class)));
+        assertThat(module.validators(), empty());
     }
 
     @Test
     void providesInternalSchemaExtensions() {
-        assertThat(module.schemaExtensions(), 
hasItem(ExtendedTableConfigurationSchema.class));
+        assertThat(module.schemaExtensions(), empty());
     }
 
     @Test
     void providesNoPolymorphicSchemaExtensions() {
-        assertThat(module.polymorphicSchemaExtensions(), 
hasItem(ConstantValueDefaultConfigurationSchema.class));
-        assertThat(module.polymorphicSchemaExtensions(), 
hasItem(FunctionCallDefaultConfigurationSchema.class));
-        assertThat(module.polymorphicSchemaExtensions(), 
hasItem(NullValueDefaultConfigurationSchema.class));
+        assertThat(module.polymorphicSchemaExtensions(), empty());

Review Comment:
   Delete it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org