ibessonov commented on code in PR #2517:
URL: https://github.com/apache/ignite-3/pull/2517#discussion_r1315809259
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -525,6 +531,18 @@ public void start() {
lowWatermark.start();
+ try {
+ metaStorageMgr.recoveryFinishedFuture()
Review Comment:
Is it safe to assert that `metaStorageMgr.recoveryFinishedFuture()` is
already completed? If so, then I would avoid `thenCompose*`, calling handlers
in current thread instead
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -560,6 +578,19 @@ public CompletableFuture<Boolean>
notify(SchemaEventParameters parameters, @Null
addMessageHandler(clusterService.messagingService());
}
+ private CompletableFuture<Void> performRebalanceOnRecovery(long revision) {
+ var startRange = new ByteArray(PENDING_ASSIGNMENTS_PREFIX);
+ var endRange = new
ByteArray(incrementLastChar(PENDING_ASSIGNMENTS_PREFIX));
Review Comment:
Would it be better to have a constant for the upper bound array as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
