ibessonov commented on code in PR #2578:
URL: https://github.com/apache/ignite-3/pull/2578#discussion_r1323120075
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableSchemaAwareIndexStorage.java:
##########
@@ -93,4 +106,13 @@ public ColumnsExtractor indexRowResolver() {
public IndexStorage storage() {
return storage;
}
+
+ /**
+ * Resolves the binary tuple buffer according to the index.
Review Comment:
What do you mean by "resolve"? Maybe it's "create", we create instance,
based on the buffer, without doing anything else
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2169,7 +2161,7 @@ private BinaryTuple extractPk(BinaryRow row) {
}
private BinaryTuple resolvePk(ByteBuffer bytes) {
- return new BinaryTuple(pkLength, bytes);
+ return pkIndexStorage.get().resolve(bytes);
Review Comment:
The fact that we must resolve lazy index storage on every tuple creation.
Looks too expensive to me. I liked "pkLenght" much more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
