tkalkirill commented on code in PR #2578:
URL: https://github.com/apache/ignite-3/pull/2578#discussion_r1324091416
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2169,7 +2161,7 @@ private BinaryTuple extractPk(BinaryRow row) {
}
private BinaryTuple resolvePk(ByteBuffer bytes) {
- return new BinaryTuple(pkLength, bytes);
+ return pkIndexStorage.get().resolve(bytes);
Review Comment:
We will only need to wait once, it’s not scary, and we’ll use
`PartitionReplicaListener#getFromPkIndex` (and similar) from now on anyway.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2169,7 +2161,7 @@ private BinaryTuple extractPk(BinaryRow row) {
}
private BinaryTuple resolvePk(ByteBuffer bytes) {
- return new BinaryTuple(pkLength, bytes);
+ return pkIndexStorage.get().resolve(bytes);
Review Comment:
We will only need to wait once, it’s not scary, and we’ll use
`PartitionReplicaListener#getFromPkIndex` (and similar) from now on anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
