ibessonov commented on code in PR #2594:
URL: https://github.com/apache/ignite-3/pull/2594#discussion_r1328320019
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java:
##########
@@ -212,13 +212,30 @@ public void lastApplied(long lastAppliedIndex, long
lastAppliedTerm) throws Stor
}
private void lastAppliedBusy(long lastAppliedIndex, long lastAppliedTerm)
throws StorageException {
+ updateMeta((lastCheckpointId, meta) ->
meta.lastApplied(lastCheckpointId, lastAppliedIndex, lastAppliedTerm));
+ }
+
+ /**
+ * Closure interface for {@link #update(UUID, PartitionMeta)}.
+ */
Review Comment:
There's no rule to force comments into a single line if they fit. And, as
far as I see in the project, such comments are usually attributed to fields,
not classes or methods. Again, what's your motivation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
