ibessonov commented on code in PR #2594:
URL: https://github.com/apache/ignite-3/pull/2594#discussion_r1328327449
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngine.java:
##########
@@ -43,6 +43,11 @@ public interface StorageEngine {
*/
void stop() throws StorageException;
+ /**
+ * Whether the data is lost upon engine restart or not.
+ */
Review Comment:
Reducing the lines is not the goal. Usually it's quite the opposite, trying
to cram everything into a smaller number of lines makes code significantly
worse.
Beauty is subjective. I like when code looks homogeneous, these's a sense of
order and structure in that case. When every method looks different, it just
feels wrong to me. That's my part of the motivation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
