sanpwc commented on code in PR #2605:
URL: https://github.com/apache/ignite-3/pull/2605#discussion_r1339689594
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -306,6 +307,8 @@ private void
doOnNewPeersConfigurationApplied(PeersAndLearners configuration) {
)
).get();
+ Set<Assignment> calculatedAssignments =
calculateAssignmentsFn.apply(tablePartitionId).get();
Review Comment:
So, just blocking get(). Nice way to get a deadlock.
And what about exception handling? What flow do we expect here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
