sanpwc commented on code in PR #2605:
URL: https://github.com/apache/ignite-3/pull/2605#discussion_r1339716421
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -306,6 +307,8 @@ private void
doOnNewPeersConfigurationApplied(PeersAndLearners configuration) {
)
).get();
+ Set<Assignment> calculatedAssignments =
calculateAssignmentsFn.apply(tablePartitionId).get();
Review Comment:
> We have already make get on ms.getAll in a few lines above
Yep, and we also have `// TODO:
https://issues.apache.org/jira/browse/IGNITE-17592` Remove synchronous wait in
a few more lines above.
Within which thread are we going to wait? Is it a raft one?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -306,6 +307,8 @@ private void
doOnNewPeersConfigurationApplied(PeersAndLearners configuration) {
)
).get();
+ Set<Assignment> calculatedAssignments =
calculateAssignmentsFn.apply(tablePartitionId).get();
Review Comment:
> We have already make get on ms.getAll in a few lines above
Yep, and we also have `// TODO:
https://issues.apache.org/jira/browse/IGNITE-17592` Remove synchronous wait in
a few more lines above.
Within which thread are we going to wait? Is it a raft one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
