sanpwc commented on code in PR #2689:
URL: https://github.com/apache/ignite-3/pull/2689#discussion_r1360869262
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1776,8 +1788,19 @@ private CompletableFuture<ReplicaResult>
processMultiEntryAction(ReadWriteMultiR
return completedFuture(new ReplicaResult(result,
null));
}
- return
validateAtTimestampAndBuildUpdateAllCommand(request, rowIdsToDelete,
lastCommitTimes, txCoordinatorId)
- .thenCompose(cmd -> applyUpdateAllCommand(cmd,
request.skipDelayedAck()))
+ return
validateOperationAgainstSchemaAtTimestamp(request.transactionId())
+ .thenCompose(
+ catalogVersion -> applyUpdateAllCommand(
+ rowIdsToDelete,
+ lastCommitTimes,
+ request.commitPartitionId(),
Review Comment:
I've added an overloaded version with request and removed initial one
because occurred that there are no usages any longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
