sanpwc commented on code in PR #2689:
URL: https://github.com/apache/ignite-3/pull/2689#discussion_r1360927957
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2860,96 +3046,19 @@ private CompletableFuture<Void>
validateAtTimestamp(UUID txId) {
}
/**
- * Chooses operation timestamp, makes validations that require it and
constructs an {@link UpdateCommand} object.
- *
- * @param request Request that is being processed.
- * @param rowUuid Row UUID.
- * @param row Row.
- * @param txCoordinatorId Transaction coordinator id.
- * @return Future that will complete with the constructed {@link
UpdateCommand} object.
- */
- private CompletableFuture<UpdateCommand>
validateAtTimestampAndBuildUpdateCommand(
- ReadWriteSingleRowReplicaRequest request,
- UUID rowUuid,
- @Nullable BinaryRow row,
- @Nullable HybridTimestamp lastCommitTimestamp,
- String txCoordinatorId
- ) {
- return validateAtTimestampAndBuildUpdateCommand(
- request.commitPartitionId().asTablePartitionId(),
- rowUuid,
- row,
- lastCommitTimestamp,
- request.transactionId(),
- request.full(),
- txCoordinatorId
- );
- }
-
- /**
- * Chooses operation timestamp, makes validations that require it and
constructs an {@link UpdateCommand} object.
+ * Chooses operation timestamp and makes schema related validations.
*
- * @param request Request that is being processed.
- * @param rowUuid Row UUID.
- * @param row Row.
- * @param txCoordinatorId Transaction coordinator id.
- * @return Future that will complete with the constructed {@link
UpdateCommand} object.
- */
- private CompletableFuture<UpdateCommand>
validateAtTimestampAndBuildUpdateCommand(
- ReadWriteSingleRowPkReplicaRequest request,
- UUID rowUuid,
- @Nullable BinaryRow row,
- @Nullable HybridTimestamp lastCommitTimestamp,
- String txCoordinatorId
- ) {
- return validateAtTimestampAndBuildUpdateCommand(
- request.commitPartitionId().asTablePartitionId(),
- rowUuid,
- row,
- lastCommitTimestamp,
- request.transactionId(),
- request.full(),
- txCoordinatorId
- );
- }
-
- /**
- * Chooses operation timestamp, makes validations that require it and
constructs an {@link UpdateCommand} object.
- *
- * @param tablePartId {@link TablePartitionId} object.
- * @param rowUuid Row UUID.
- * @param row Row.
* @param txId Transaction ID.
- * @param full {@code True} if this is a full transaction.
- * @param txCoordinatorId Transaction coordinator id.
- * @return Future that will complete with the constructed {@link
UpdateCommand} object.
+ * @return Future that will complete with catalog version associated with
given operation though the operation timestamp.
*/
- private CompletableFuture<UpdateCommand>
validateAtTimestampAndBuildUpdateCommand(
- TablePartitionId tablePartId,
- UUID rowUuid,
- @Nullable BinaryRow row,
- @Nullable HybridTimestamp lastCommitTimestamp,
- UUID txId,
- boolean full,
- String txCoordinatorId
- ) {
+ private CompletableFuture<Integer>
validateOperationAgainstSchemaAtTimestamp(UUID txId) {
Review Comment:
Agree. I've renamed it to `validateOperationAgainstSchema()` as you've
suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
