sanpwc commented on code in PR #2701:
URL: https://github.com/apache/ignite-3/pull/2701#discussion_r1362340249
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2653,6 +2653,8 @@ private CompletableFuture<Boolean>
ensureReplicaIsPrimary(ReplicaRequest request
expectedTerm = ((ReadOnlyDirectReplicaRequest)
request).enlistmentConsistencyToken();
assert expectedTerm != null;
+ } else if (request instanceof BuildIndexReplicaRequest) {
+ expectedTerm = ((BuildIndexReplicaRequest)
request).enlistmentConsistencyToken();
Review Comment:
If got term doesn't match an expected one, you will get
PrimaryReplicaMissException. How do you handle it?
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/index/IndexBuilderTest.java:
##########
@@ -50,6 +50,8 @@ public class IndexBuilderTest extends BaseIgniteAbstractTest {
private static final int PARTITION_ID = 3;
+ private static final long ANY_ENLISTMENT_CONSISTENCY_TOKEN = 100500;
Review Comment:
We've also agreed that you will adjust PrimaryReplicaMissException. I cant
see such changes in given PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
