tkalkirill commented on code in PR #2701:
URL: https://github.com/apache/ignite-3/pull/2701#discussion_r1363559105
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -484,22 +484,22 @@ private CompletableFuture<?>
processOperationRequest(ReplicaRequest request, @Nu
*/
private CompletableFuture<LeaderOrTxState>
processTxStateCommitPartitionRequest(TxStateCommitPartitionRequest request) {
return placementDriver.getPrimaryReplica(replicationGroupId,
hybridClock.now())
- .thenCompose(primaryReplica -> {
- if (primaryReplica == null) {
- return failedFuture(new
PrimaryReplicaMissException(localNode.name(), null));
+ .thenCompose(primaryReplicaMeta -> {
Review Comment:
Because the future does not return the primary replica, but the meta of the
primary replica (`org.apache.ignite.internal.placementdriver.ReplicaMeta`).
Without the "meta" postfix, the variable name confuses me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
