AMashenkov commented on code in PR #2785:
URL: https://github.com/apache/ignite-3/pull/2785#discussion_r1381408052
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java:
##########
@@ -29,20 +39,38 @@
/**
* Embedded implementation of the Ignite SQL query facade.
*/
-public class IgniteSqlImpl implements IgniteSql {
+public class IgniteSqlImpl implements IgniteSql, IgniteComponent {
+ private static final IgniteLogger LOG =
Loggers.forClass(IgniteSqlImpl.class);
+
+ /** Session expiration check period in milliseconds. */
+ private static final long SESSION_EXPIRE_CHECK_PERIOD =
TimeUnit.SECONDS.toMillis(1);
+
private final QueryProcessor qryProc;
private final IgniteTransactions transactions;
+ /** Session expiration worker. */
+ private final ScheduledExecutorService executor;
+
+ private final ConcurrentMap<SessionId, SessionImpl> sessions = new
ConcurrentHashMap<>();
Review Comment:
Should we cleanup collection on component stop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
