korlov42 commented on code in PR #2785:
URL: https://github.com/apache/ignite-3/pull/2785#discussion_r1381745432
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/AsyncResultSetImpl.java:
##########
@@ -108,8 +122,10 @@ public boolean wasApplied() {
public Iterable<T> currentPage() {
requireResultSet();
+ expirationTracker.touch();
Review Comment:
I would prefer not to. `requireResultSet` does exactly what you expect it to
do by looking at its name. Touch of the expiration tracker will be a side
effect. We may move it inside, but then we need to come up with a proper name
like `ensureResultSetAwailableAndTouchExpirationTracker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
