Flaugh24 commented on code in PR #2817:
URL: https://github.com/apache/ignite-3/pull/2817#discussion_r1388322302
##########
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/ConfigurationChanger.java:
##########
@@ -295,6 +310,17 @@ private void persistDefaults() {
});
}
+ /**
+ * Initializes the configuration with the given source. This method should
be used only for the initial setup of the configuration. The
+ * configuration is initialized with the provided source only if the
storage is empty, and it is saved along with the defaults. This
+ * method must be called before {@link #start()}.
+ *
+ * @param cfg the configuration source to initialize with.
+ */
+ public void initializeConfigurationWith(ConfigurationSource cfg) {
+ initialConfiguration = cfg;
Review Comment:
The method should be called before `start`. If it's called after `start`,
the provided configuration will be ignored. However, it's a valid situation if
the method was not called before `start`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
