Flaugh24 commented on code in PR #2817:
URL: https://github.com/apache/ignite-3/pull/2817#discussion_r1388353079
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1049,8 +1044,23 @@ public void init(
}
/**
- * Recovers components state on start by invoking configuration listeners
({@link #notifyConfigurationListeners()}
- * and deploying watches after that.
+ * Initializes the cluster configuration with the specified user-provided
configuration upon cluster initialization.
+ */
+ private CompletableFuture<Void>
initializeClusterConfiguration(ExecutorService startupExecutor) {
+ return cmgMgr.initialClusterConfigurationFuture().thenAcceptAsync(cfg
-> {
+ if (cfg == null) {
+ return;
+ }
Review Comment:
Now`ConfigurationChanger#initialConfiguration` is `EMPTY_CFG_SRC` by default.
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1049,8 +1044,23 @@ public void init(
}
/**
- * Recovers components state on start by invoking configuration listeners
({@link #notifyConfigurationListeners()}
- * and deploying watches after that.
+ * Initializes the cluster configuration with the specified user-provided
configuration upon cluster initialization.
+ */
+ private CompletableFuture<Void>
initializeClusterConfiguration(ExecutorService startupExecutor) {
+ return cmgMgr.initialClusterConfigurationFuture().thenAcceptAsync(cfg
-> {
+ if (cfg == null) {
+ return;
+ }
Review Comment:
Now `ConfigurationChanger#initialConfiguration` is `EMPTY_CFG_SRC` by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
