sanpwc commented on code in PR #2820:
URL: https://github.com/apache/ignite-3/pull/2820#discussion_r1389422294
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -1587,34 +1594,53 @@ private CompletableFuture<Object> finishTransaction(
HybridTimestamp tsForCatalogVersion = commit ? commitTimestamp :
hybridClock.now();
return reliableCatalogVersionFor(tsForCatalogVersion)
- .thenCompose(catalogVersion -> {
- synchronized (commandProcessingLinearizationMutex) {
- FinishTxCommandBuilder finishTxCmdBldr =
MSG_FACTORY.finishTxCommand()
- .txId(txId)
- .commit(commit)
- .safeTimeLong(hybridClock.nowLong())
- .txCoordinatorId(txCoordinatorId)
- .requiredCatalogVersion(catalogVersion)
- .tablePartitionIds(
- aggregatedGroupIds.stream()
-
.map(PartitionReplicaListener::tablePartitionId)
- .collect(toList())
- );
-
- if (commit) {
-
finishTxCmdBldr.commitTimestampLong(commitTimestamp.longValue());
- }
-
- return raftClient.run(finishTxCmdBldr.build());
- }
- })
+ .thenCompose(catalogVersion -> applyFinishCommand(
+ txId,
+ commit,
+ commitTimestamp,
+ txCoordinatorId,
+ catalogVersion,
+ aggregatedGroupIds.stream()
+
.map(PartitionReplicaListener::tablePartitionId)
+ .collect(toList())
+ )
+ )
.whenComplete((o, throwable) -> {
TxState txState = commit ? COMMITED : ABORTED;
markFinished(txId, txState, commitTimestamp);
});
}
+ private CompletableFuture<Object> applyFinishCommand(
+ UUID transactionId,
+ boolean commit,
+ HybridTimestamp commitTimestamp,
+ String txCoordinatorId,
+ int catalogVersion,
+ List<TablePartitionIdMessage> tablePartitionIds
+ ) {
+ // TODO: synchonized should go here. Not within finishTransaction but
with all apply command.
Review Comment:
TODO was outdated. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
