sanpwc commented on code in PR #2820:
URL: https://github.com/apache/ignite-3/pull/2820#discussion_r1389476809
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2383,6 +2424,35 @@ private CompletableFuture<Object>
applyCmdWithExceptionHandling(Command cmd) {
});
}
+ private void applyCmdWithRetryOnSafeTimeReorderException(Command cmd,
CompletableFuture<Object> resultFuture) {
+ raftClient.run(cmd).whenComplete((res, ex) -> {
+ if (ex != null) {
+ if (ex instanceof SafeTimeReorderException || ex.getCause()
instanceof SafeTimeReorderException) {
+ assert cmd instanceof SafeTimePropagatingCommand;
Review Comment:
Do you mean that applyCmdWithRetryOnSafeTimeReorderException should have
SafeTimePropagatingCommand instead of Command as a parameter? I don't think
it's convenient because in that case we should skip calling
applyCmdWithRetryOnSafeTimeReorderException for all commands except
SafeTimePropagatingCommand and skip raftClientRun directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
