Cyrill commented on code in PR #2832:
URL: https://github.com/apache/ignite-3/pull/2832#discussion_r1392531740
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxStateMetaFinishing.java:
##########
@@ -35,9 +36,10 @@ public class TxStateMetaFinishing extends TxStateMeta {
* Constructor.
*
* @param txCoordinatorId Transaction coordinator id.
+ * @param commitPartitionId Commit partition id.
*/
- public TxStateMetaFinishing(String txCoordinatorId) {
- super(TxState.FINISHING, txCoordinatorId, null);
+ public TxStateMetaFinishing(String txCoordinatorId, ReplicationGroupId
commitPartitionId) {
Review Comment:
Please mark commitPartitionId as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
