vldpyatkov commented on code in PR #2832:
URL: https://github.com/apache/ignite-3/pull/2832#discussion_r1393830157


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadOnlyTransactionImpl.java:
##########
@@ -116,7 +116,7 @@ public CompletableFuture<Void> finish(boolean commit, 
HybridTimestamp executionT
         return ((TxManagerImpl) 
txManager).completeReadOnlyTransactionFuture(new 
TxIdAndTimestamp(readTimestamp, id()))
                 .thenRun(() -> txManager.updateTxMeta(
                         id(),
-                        old -> new TxStateMeta(COMMITED, 
old.txCoordinatorId(), old.commitTimestamp())
+                        old -> new TxStateMeta(COMMITED, 
old.txCoordinatorId(), null, old.commitTimestamp())

Review Comment:
   I don't think that commit partitioning for RO transactions is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to