ptupitsyn commented on code in PR #2825:
URL: https://github.com/apache/ignite-3/pull/2825#discussion_r1395669747
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -204,6 +212,7 @@ public void start() {
@Override
public void stop() throws Exception {
metricManager.unregisterSource(metrics);
Review Comment:
1. All the logic in this method is idempotent, so `stopGuard` does not
matter.
2. As I understand, `busyLock` won't do anything either. All external input
for this module comes through Netty. We can't wait for clients to disconnect in
a busy lock. We just drop them by closing the channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
