ptupitsyn commented on code in PR #2825:
URL: https://github.com/apache/ignite-3/pull/2825#discussion_r1395678093
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -177,6 +182,7 @@ public ClientHandlerModule(
this.clock = clock;
this.schemaSyncService = schemaSyncService;
this.catalogService = catalogService;
+ this.primaryReplicaTracker = new
ClientPrimaryReplicaTracker(placementDriver, igniteTables, catalogService,
clock);
Review Comment:
Catalog does not provide the number of partitions for a given table, which
is needed in `initReplicasForTableAsync`. That's the only reason to pull
`igniteTables` in there.
It would be great to get rid of `igniteTables` if we can retrieve the
partition count from `PlacementDriver` or `CatalogService`, but I could not
find a way to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
