tkalkirill commented on code in PR #2838:
URL: https://github.com/apache/ignite-3/pull/2838#discussion_r1398829245
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/PersistentPageMemoryDataRegionConfigurationSchema.java:
##########
@@ -29,7 +30,8 @@
@Config
public class PersistentPageMemoryDataRegionConfigurationSchema extends
BasePageMemoryDataRegionConfigurationSchema {
/** Default size. */
Review Comment:
Suggestion: Modify comment, ", maximum of 256 MB or 20% of the total memory
on the physical device."
##########
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java:
##########
@@ -157,6 +159,28 @@ public static int majorJavaVersion(String verStr) {
}
}
+ /**
+ * Returns the amount of RAM memory available on this machine.
+ *
+ * @return Total amount of memory in bytes or -1 if any exception happened.
Review Comment:
```suggestion
* @return Total amount of memory in bytes or {@code -1} if any
exception happened.
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/VolatilePageMemoryDataRegionConfigurationSchema.java:
##########
@@ -29,10 +30,11 @@
@Config
public class VolatilePageMemoryDataRegionConfigurationSchema extends
BasePageMemoryDataRegionConfigurationSchema {
/** Default initial size. */
Review Comment:
Same
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RemoveWriteOnGcInvokeClosure.java:
##########
@@ -76,14 +79,16 @@ public void call(@Nullable VersionChain oldRow) throws
IgniteInternalCheckedExce
result = nextRowVersion;
+ assert result.nextLink() == NULL_LINK;
Review Comment:
Maybe print a link in the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
