rpuch commented on code in PR #2838:
URL: https://github.com/apache/ignite-3/pull/2838#discussion_r1399204142
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/PersistentPageMemoryDataRegionConfigurationSchema.java:
##########
@@ -29,7 +29,10 @@
*/
@Config
public class PersistentPageMemoryDataRegionConfigurationSchema extends
BasePageMemoryDataRegionConfigurationSchema {
- /** Default size, maximum between 256 MB and 20% of the total physical
memory. */
+ /**
+ * Default size, maximum between 256 MiB and 20% of the total physical
memory.
+ * 256 MiB, is system was unable to retrieve physical memory size.
Review Comment:
```suggestion
* 256 MiB, if system was unable to retrieve physical memory size.
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/configuration/schema/VolatilePageMemoryDataRegionConfigurationSchema.java:
##########
@@ -29,7 +29,10 @@
*/
@Config
public class VolatilePageMemoryDataRegionConfigurationSchema extends
BasePageMemoryDataRegionConfigurationSchema {
- /** Default initial size, maximum between 256 MB and 20% of the total
physical memory. */
+ /**
+ * Default initial size, maximum between 256 MiB and 20% of the total
physical memory.
+ * 256 MiB, is system was unable to retrieve physical memory size.
Review Comment:
```suggestion
* 256 MiB, if system was unable to retrieve physical memory size.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
