rpuch commented on code in PR #2872: URL: https://github.com/apache/ignite-3/pull/2872#discussion_r1404439730
########## modules/runner/src/integrationTest/java/org/apache/ignite/internal/schemasync/ItSchemaForwardCompatibilityTest.java: ########## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.schemasync; + +import static org.apache.ignite.internal.SessionUtils.executeUpdate; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsString; +import static org.hamcrest.Matchers.is; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import org.apache.ignite.internal.Cluster; +import org.apache.ignite.internal.ClusterPerTestIntegrationTest; +import org.apache.ignite.internal.app.IgniteImpl; +import org.apache.ignite.internal.table.TableViewInternal; +import org.apache.ignite.internal.tx.InternalTransaction; +import org.apache.ignite.internal.tx.TxState; +import org.apache.ignite.lang.ErrorGroups.Transactions; +import org.apache.ignite.table.Table; +import org.apache.ignite.table.Tuple; +import org.apache.ignite.tx.Transaction; +import org.apache.ignite.tx.TransactionException; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +/** + * Tests about forward compatibility of table schemas as defined by IEP-110. + * + * @see <a href="https://cwiki.apache.org/confluence/display/IGNITE/IEP-110%3A+Schema+synchronization%3A+basic+schema+changes";>IEP-110</a> + */ +class ItSchemaForwardCompatibilityTest extends ClusterPerTestIntegrationTest { + private static final int NODES_TO_START = 1; + + private static final String TABLE_NAME = "test"; + + private IgniteImpl node; + + @Override + protected int initialNodes() { + return NODES_TO_START; + } + + @BeforeEach + void assignNode() { + node = cluster.node(0); + } + + /** + * Makes sure forward-compatible schema changes happenning between transaction operations and + * commit do not prevent a commit from happening. + */ + @ParameterizedTest + @EnumSource(ForwardCompatibleDdl.class) + void forwardCompatibleSchemaChangesAllowCommitting(ForwardCompatibleDdl ddl) { + createTable(); + + Transaction tx = node.transactions().begin(); + + writeIn(tx); + + ddl.executeOn(cluster); Review Comment: The tests would fail for another reason (on write, not on commit). This is because we don't allow any reads or writes in an RW transaction if there was a DDL concerning the given table between the transaction start and the operation. This PR is about forward compatibility that only makes sense at commit time. That's why I do a write (just to enlist the table with the tx), then DDL and then commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
