rpuch commented on code in PR #2872:
URL: https://github.com/apache/ignite-3/pull/2872#discussion_r1405752961
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/schema/FullTableSchemaTest.java:
##########
@@ -29,17 +29,8 @@
import org.junit.jupiter.api.Test;
class FullTableSchemaTest {
- @Test
- void sameSchemasHaveEmptyDiff() {
- CatalogTableColumnDescriptor column = someColumn("a");
-
- var schema1 = new FullTableSchema(1, 1, List.of(column));
- var schema2 = new FullTableSchema(2, 1, List.of(column));
-
- TableDefinitionDiff diff = schema2.diffFrom(schema1);
-
- assertThat(diff.isEmpty(), is(true));
- }
+ private static final String TABLE_NAME1 = "test1";
Review Comment:
Because the tested method is not needed and I was going to delete it as
well, but forgot to do so. Thanks for noticing, I've removed the tested method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
