yurinaryshkin commented on code in PR #11057:
URL: https://github.com/apache/ignite/pull/11057#discussion_r1410258544


##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -135,13 +151,51 @@ public DumpReader(DumpReaderConfiguration cfg, 
IgniteLogger log) {
                                     return;
                                 }
 
-                                try (DumpedPartitionIterator iter = 
dump.iterator(node, grp, part)) {
+                                try (DumpedPartitionIterator iter = new 
DumpedPartitionIterator() {
+                                    /** */
+                                    final DumpedPartitionIterator delegate = 
dump.iterator(node, grp, part);
+
+                                    /** */
+                                    final AtomicBoolean 
consumerProcessingEntry = new AtomicBoolean(false);

Review Comment:
   No. We can increment recordsProcessed only when consumer finishes processing 
record, after which hasNext() executed. If we switch only to using next() then 
we can detect processing of previous record, which means that we can't detect 
processing of last record, for which normally hasNext() is executed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to