yurinaryshkin commented on code in PR #11057:
URL: https://github.com/apache/ignite/pull/11057#discussion_r1410342366


##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -135,13 +151,51 @@ public DumpReader(DumpReaderConfiguration cfg, 
IgniteLogger log) {
                                     return;
                                 }
 
-                                try (DumpedPartitionIterator iter = 
dump.iterator(node, grp, part)) {
+                                try (DumpedPartitionIterator iter = new 
DumpedPartitionIterator() {
+                                    /** */
+                                    final DumpedPartitionIterator delegate = 
dump.iterator(node, grp, part);
+
+                                    /** */
+                                    final AtomicBoolean 
consumerProcessingEntry = new AtomicBoolean(false);

Review Comment:
   We can't rely on hasNext() because we don't know how many times consumer 
will execute hasNext() per each record. It is not prohibited to invoke 
hasNext() several times for example like this
   ```
   while (it.hasNext()) {
     process(it.next());
   
     if (!it.hasNext())
       log.info("Processed last record");
   } 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to