lowka commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1410425643
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -516,12 +522,16 @@ private List<AbstractNode<?>> localFragments() {
private CompletableFuture<Void> sendFragment(
String targetNodeName, String serialisedFragment,
FragmentDescription desc, TxAttributes txAttributes
) {
+ Object[] parameterValues = Arrays.stream(ctx.parameters())
+ .map((v) -> v.value())
+ .toArray();
Review Comment:
I agree, but at the moment there is no separation between prepare and
execution and because of that they share the same context class , when in fact
for execution we only need exact values ((param_indes, value) ) and for
preparation we need (param_index, value/no_value).
Maybe it would be better to fix this when we introduce a separate
preparation phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
