AMashenkov commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1410457151
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/DynamicParametersTest.java:
##########
@@ -87,11 +105,31 @@ public Stream<DynamicTest> testInExpression() {
String error =
"Values passed to IN operator must have compatible types.
Dynamic parameter requires adding explicit type cast";
return Stream.of(
- sql("SELECT ? IN ('1', '2')", 1).project("OR(=(?0, 1), =(?0,
2))"),
+ sql("SELECT ? IN ('1', '2')",
1).parameterTypes(nullable(NativeTypes.INT32)).project("OR(=(?0, 1), =(?0,
2))"),
sql("SELECT ? IN (1, 2)", "1").fails(error),
- sql("SELECT ? IN ('1', 2)", 2).project("OR(=(?0, 1), =(?0,
2))"),
+ sql("SELECT ? IN (1, 2)",
1).parameterTypes(nullable(NativeTypes.INT32)).project("OR(=(?0, 1), =(?0,
2))"),
+
+ // sql("SELECT ? IN (1)", Unspecified.UNKNOWN)
+ // .fails("Unable to determine type of a
dynamic parameter#0"),
+ // sql("SELECT ? IN (?, 1)", Unspecified.UNKNOWN,
Unspecified.UNKNOWN)
+ // .fails("Unable to determine type of a
dynamic parameter#0"),
+ // sql("SELECT ? IN (?, ?)", Unspecified.UNKNOWN,
Unspecified.UNKNOWN, Unspecified.UNKNOWN)
+ // .fails("Unable to determine type of a
dynamic parameter#0"),
Review Comment:
Are these cases broken? Let's add a TODO with a ticket to fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
