ygerzhedovich commented on code in PR #2912:
URL: https://github.com/apache/ignite-3/pull/2912#discussion_r1413529455
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -578,19 +586,12 @@ private CompletableFuture<Void> executeFragment(IgniteRel
treeRoot, ResolvedDepe
if (!(node instanceof Outbox)) {
Function<RowT, RowT> internalTypeConverter =
TypeUtils.resultTypeConverter(ectx, treeRoot.getRowType());
- AsyncRootNode<RowT, List<Object>> rootNode = new
AsyncRootNode<>(node, inRow -> {
- inRow = internalTypeConverter.apply(inRow);
-
- int rowSize = ectx.rowHandler().columnCount(inRow);
-
- List<Object> res = new ArrayList<>(rowSize);
-
- for (int i = 0; i < rowSize; i++) {
- res.add(ectx.rowHandler().get(i, inRow));
- }
-
- return res;
- });
+ AsyncRootNode<RowT, InternalSqlRow> rootNode = new
AsyncRootNode<>(
+ node,
+ inRow -> {
+ inRow = internalTypeConverter.apply(inRow);
Review Comment:
it still required for Date/Time types at least. Otherwise we have uncovered
from internal representation values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
