ygerzhedovich commented on code in PR #2912:
URL: https://github.com/apache/ignite-3/pull/2912#discussion_r1417645912


##########
modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java:
##########
@@ -213,4 +217,29 @@ public static Object generateValueByType(int base, 
ColumnType type) {
                 throw new IllegalArgumentException("unsupported type " + type);
         }
     }
+
+    /**
+     * Converts list of {@link InternalSqlRow} to list of list of objects, 
where internal list represent a row with fields.
+     *
+     * @param rows List
+     * @return List of converted rows.
+     */
+    public static List<List<?>> convertSqlRows(List<InternalSqlRow> rows) {

Review Comment:
   ok



##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcStatement.java:
##########
@@ -164,9 +167,26 @@ protected void execute0(JdbcStatementType stmtType, String 
sql, Object[] args) t
         JdbcQueryCursorHandler handler = new 
JdbcClientQueryCursorHandler(result.getChannel());
 
         for (JdbcQuerySingleResult jdbcRes : executeResult.results()) {
+            int columnCount = jdbcRes.columnTypes().size();
+            Function<BinaryTupleReader, List<Object>> transformer = (tuple) -> 
{
+                List<ColumnType> columnTypes = jdbcRes.columnTypes();
+                int[] decimalScales = jdbcRes.decimalScales();

Review Comment:
   good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to