lowka commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1414104165


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/metrics/PlanningCacheMetricsTest.java:
##########
@@ -56,20 +56,20 @@ public void plannerCacheStatisticsTest() throws Exception {
         MetricSet metricSet = 
metricManager.enable(SqlPlanCacheMetricSource.NAME);
 
         try {

Review Comment:
   Now we have 1 additional read be prepare with no dynamic params or with all 
parameters set.



##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/metrics/PlanningCacheMetricsTest.java:
##########
@@ -56,20 +56,20 @@ public void plannerCacheStatisticsTest() throws Exception {
         MetricSet metricSet = 
metricManager.enable(SqlPlanCacheMetricSource.NAME);
 
         try {

Review Comment:
   Now we have 1 additional read per prepare with no dynamic params or with all 
parameters set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to