korlov42 commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1418859079
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -513,6 +570,27 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>>
queryScript0(
return parseFut;
}
+ private CompletableFuture<QueryPlan> prepareParsedStatement(String
schemaName,
+ ParsedResult parsedResult,
+ HybridTimestamp timestamp,
+ QueryCancel queryCancel,
+ Object[] params) {
+
+ return waitForActualSchema(schemaName, timestamp)
+ .thenCompose(schema -> {
+ Map<Integer, Object> dynamicParams =
Commons.arrayToMap(params);
Review Comment:
map is only required by planner, so it's better to convert parameters once
if it really required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
