sanpwc commented on code in PR #2867:
URL: https://github.com/apache/ignite-3/pull/2867#discussion_r1423605282


##########
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java:
##########
@@ -451,6 +451,14 @@ Publisher<BinaryRow> lookup(
      */
     RaftGroupService partitionRaftGroupService(int partition);
 
+    /**
+     * Returns raft group client for corresponding partition.
+     *
+     * @param partition Partition number.
+     * @return Whether raft group client for corresponding partition is 
started.
+     */
+    boolean partitionRaftGroupServiceStarted(int partition);

Review Comment:
   Yep, but why we need it? I mean it's used in order to check whether it's 
required to start raft server on handling changePendingAssignmentEvent: if 
there's server up and running - no need to start it. But why not to compare 
assignments.stable and assignments.pending and start (assignments.pending - 
assignments.stable)?
   
   As far as I remember we've discussed similar topic several months ago with 
@kgusakov thus he may have some concerns here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to