sanpwc commented on code in PR #2867:
URL: https://github.com/apache/ignite-3/pull/2867#discussion_r1423717631
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -526,39 +524,51 @@ public void start() {
});
}
- private void performRebalanceOnRecovery(long recoveryRevision) {
- CompletableFuture<Void> pendingAssignmentsRecoveryFuture;
+ private void processAssignmentsOnRecovery(long recoveryRevision) {
+ var pendingAssignmentsPrefix = new
ByteArray(PENDING_ASSIGNMENTS_PREFIX);
- var prefix = new ByteArray(PENDING_ASSIGNMENTS_PREFIX);
+ startVv.update(recoveryRevision, (v, e) -> handleAssignmentsOnRecovery(
+ pendingAssignmentsPrefix,
+ recoveryRevision,
+ (entry, rev) -> handleChangePendingAssignmentEvent(entry, rev,
true),
+ "pending"
+ ));
+ }
- try (Cursor<Entry> cursor = metaStorageMgr.prefixLocally(prefix,
recoveryRevision)) {
+ private CompletableFuture<Void> handleAssignmentsOnRecovery(
Review Comment:
As mentioned above `processAssignmentsOnRecovery` is only used to handle
pending assignments and not the stable one. Thus either approach or naming is
misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
