lowka commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1424244569
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImplTest.java:
##########
@@ -103,18 +118,158 @@ void prepareServiceCachesPlanCreatedForExplain() {
assertThat(plan.plan(), sameInstance(queryPlan));
}
+ @Test
+ void prepareReturnsQueryPlanThatDependsOnParameterTypeMatchInferred() {
+ PrepareService service = createPlannerService();
+
+ QueryPlan queryPlan1 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext()
+ ));
+
+ List<ColumnType> parameterTypes =
queryPlan1.parameterMetadata().parameterTypes()
+ .stream()
+ .map(ParameterType::columnType)
+ .collect(Collectors.toList());
+
+ assertEquals(List.of(ColumnType.INT64, ColumnType.INT32),
parameterTypes);
+
+ // Parameter types match, we should return plan1.
+ QueryPlan queryPlan2 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext(1L, 1))
+ );
+ assertSame(queryPlan1, queryPlan2);
+
+ // Parameter types do not match
+ QueryPlan queryPlan3 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext(1, 1L)
+ ));
+ assertNotSame(queryPlan1, queryPlan3);
+ }
+
+ @Test
+ void prepareReturnsDmlPlanThatDependsOnParameterTypeMatchInferred() {
Review Comment:
Fixed.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImplTest.java:
##########
@@ -103,18 +118,158 @@ void prepareServiceCachesPlanCreatedForExplain() {
assertThat(plan.plan(), sameInstance(queryPlan));
}
+ @Test
+ void prepareReturnsQueryPlanThatDependsOnParameterTypeMatchInferred() {
+ PrepareService service = createPlannerService();
+
+ QueryPlan queryPlan1 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext()
+ ));
+
+ List<ColumnType> parameterTypes =
queryPlan1.parameterMetadata().parameterTypes()
+ .stream()
+ .map(ParameterType::columnType)
+ .collect(Collectors.toList());
+
+ assertEquals(List.of(ColumnType.INT64, ColumnType.INT32),
parameterTypes);
+
+ // Parameter types match, we should return plan1.
+ QueryPlan queryPlan2 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext(1L, 1))
+ );
+ assertSame(queryPlan1, queryPlan2);
+
+ // Parameter types do not match
+ QueryPlan queryPlan3 = await(service.prepareAsync(
+ parse("SELECT * FROM t WHERE a = ? and c = ?"),
+ createContext(1, 1L)
+ ));
+ assertNotSame(queryPlan1, queryPlan3);
+ }
+
+ @Test
+ void prepareReturnsDmlPlanThatDependsOnParameterTypeMatchInferred() {
+ PrepareService service = createPlannerService();
+
+ QueryPlan queryPlan1 = await(service.prepareAsync(
+ parse("UPDATE t SET a = ? WHERE c = ?"),
+ createContext()
+ ));
+
+ List<ColumnType> parameterTypes =
queryPlan1.parameterMetadata().parameterTypes()
+ .stream()
+ .map(ParameterType::columnType)
+ .collect(Collectors.toList());
+
+ assertEquals(List.of(ColumnType.INT64, ColumnType.INT32),
parameterTypes);
+
+ // Parameter types match, we should return plan1.
+ QueryPlan queryPlan2 = await(service.prepareAsync(
+ parse("UPDATE t SET a = ? WHERE c = ?"),
+ createContext(1L, 1)
+ ));
+ assertSame(queryPlan1, queryPlan2);
+
+ // Parameter types do not match
+ QueryPlan queryPlan3 = await(service.prepareAsync(
+ parse("UPDATE t SET a = ? WHERE c = ?"),
+ createContext(1, 1L)
+ ));
+ assertNotSame(queryPlan1, queryPlan3);
+ }
+
+ @Test
+ void preparePropagatesValidationError() {
Review Comment:
Fixed.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImplTest.java:
##########
@@ -103,18 +118,158 @@ void prepareServiceCachesPlanCreatedForExplain() {
assertThat(plan.plan(), sameInstance(queryPlan));
}
+ @Test
+ void prepareReturnsQueryPlanThatDependsOnParameterTypeMatchInferred() {
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
