lowka commented on code in PR #2857:
URL: https://github.com/apache/ignite-3/pull/2857#discussion_r1424086026
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -485,6 +580,37 @@ public RelDataType deriveType(SqlValidatorScope scope,
SqlNode expr) {
return dataType;
}
+ /** {@inheritDoc} */
+ @Override public RelDataType getParameterRowType(SqlNode sqlQuery) {
+ // We do not use calcite' version since it is contains a bug,
+ // alreadyVisited visited uses object identity, but rewrites of
NULLIF, COALESCE
+ // into dynamic parameters may place the same parameter into multiple
positions
+ // in SQL tree.
+ List<RelDataType> types = new ArrayList<>();
+ Set<Integer> alreadyVisited = new HashSet<>();
Review Comment:
Absolutely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
