simon-greatrix commented on code in PR #11046:
URL: https://github.com/apache/ignite/pull/11046#discussion_r1425376619


##########
modules/core/src/main/java/org/apache/ignite/spi/metric/jmx/ReadOnlyDynamicMBean.java:
##########
@@ -57,16 +58,18 @@ else if ("invoke".equals(actionName))
 
     /** {@inheritDoc} */
     @Override public AttributeList getAttributes(String[] attributes) {
-        AttributeList list = new AttributeList();
-
+        AttributeList attrList = new AttributeList();
+        List<Attribute> list = attrList.asList();
         try {
-            for (String attr : attributes) {

Review Comment:
   Fine. Old name wasn't very good :) - it really should have been "name" to 
distinguish between the attribute instance, the attribute value and the 
attribute name.
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to