NSAmelchev commented on code in PR #11046:
URL: https://github.com/apache/ignite/pull/11046#discussion_r1425427017
##########
modules/core/src/main/java/org/apache/ignite/spi/metric/jmx/ReadOnlyDynamicMBean.java:
##########
@@ -57,16 +58,18 @@ else if ("invoke".equals(actionName))
/** {@inheritDoc} */
@Override public AttributeList getAttributes(String[] attributes) {
- AttributeList list = new AttributeList();
-
+ AttributeList attrList = new AttributeList();
+ List<Attribute> list = attrList.asList();
try {
- for (String attr : attributes) {
- Object val = getAttribute(attr);
-
- list.add(val);
+ for (String attribute : attributes) {
+ Object val = getAttribute(attribute);
Review Comment:
See table above. The section `Between minimal semantic units in the method
or initializer body` says to use 1 line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
