denis-chudov commented on code in PR #2867:
URL: https://github.com/apache/ignite-3/pull/2867#discussion_r1431180179
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -1191,6 +1207,90 @@ public void updateClusterCfgWithDefaultValue() {
startNodes(3);
}
+ @Test
+ public void destroyObsoleteStoragesOnRestart() throws InterruptedException
{
+ int nodesCount = 3;
+ List<IgniteImpl> nodes = startNodes(nodesCount);
+
+ int partitions = nodesCount;
+ int replicas = nodesCount;
+ createTableWithData(nodes, TABLE_NAME, replicas, partitions);
+
+ int restartedNodeIndex = nodesCount - 1;
+
+ WatchListenerInhibitor inhibitor =
WatchListenerInhibitor.metastorageEventsInhibitor(nodes.get(restartedNodeIndex));
+
+ inhibitor.startInhibit();
+
+ // Change the zone - one replica per partition.
+ alterZone(nodes.get(0).catalogManager(), String.format("ZONE_%s",
TABLE_NAME.toUpperCase()), 1);
+
+ stopNode(restartedNodeIndex);
+
+ inhibitor.stopInhibit();
+
+ IgniteImpl restartedNode = startNode(restartedNodeIndex);
+
+ TableImpl table = (TableImpl) restartedNode.tables().table(TABLE_NAME);
+
+ assertTrue(waitForCondition(() -> {
+ // Check that only storage for 1 partition left on the restarted
node.
+ return IntStream.range(0, partitions)
+ .mapToObj(i ->
table.internalTable().storage().getMvPartition(i))
+ .filter(Objects::nonNull)
+ .count() == 1;
+ }, 10_000));
+ }
+
+ @Test
+ public void testCorrectPartitionRecoveryOnSnapshot() throws
InterruptedException {
+ int nodesCount = 3;
+ List<IgniteImpl> nodes = startNodes(nodesCount);
+
+ int partitions = nodesCount;
+ int replicas = nodesCount;
+ createTableWithData(nodes, TABLE_NAME, replicas, partitions);
+
+ int restartedNodeIndex = nodesCount - 1;
+
+ WatchListenerInhibitor inhibitor =
WatchListenerInhibitor.metastorageEventsInhibitor(nodes.get(restartedNodeIndex));
+
+ inhibitor.startInhibit();
+
+ alterZone(nodes.get(0).catalogManager(), String.format("ZONE_%s",
TABLE_NAME.toUpperCase()), 1);
+
+ stopNode(restartedNodeIndex);
+
+ inhibitor.stopInhibit();
+
+ forceSnapshotUsageOnRestart(nodes.get(0));
+
+ IgniteImpl restartedNode = startNode(restartedNodeIndex);
+
+ TableImpl table = (TableImpl) restartedNode.tables().table(TABLE_NAME);
+
+ long recoveryRevision =
restartedNode.metaStorageManager().recoveryFinishedFuture().join();
+
+ for (int p = 0; p < partitions; p++) {
+ TablePartitionId tablePartitionId = new
TablePartitionId(table.tableId(), p);
+
+ Entry e =
restartedNode.metaStorageManager().getLocally(stablePartAssignmentsKey(tablePartitionId),
recoveryRevision);
+
+ Set<Assignment> assignment = ByteUtils.fromBytes(e.value());
+
+ boolean shouldBe = assignment.stream().anyMatch(n ->
n.consistentId().equals(restartedNode.name()));
+
+ PeersAndLearners configuration =
PeersAndLearners.fromConsistentIds(assignment.stream().map(a ->
a.consistentId()).collect(
+ Collectors.toSet()), Set.of());
+
+ Peer peer = configuration.peer(restartedNode.name());
+
+ boolean isStarted = peer == null ? false :
restartedNode.raftManager().isStarted(new RaftNodeId(tablePartitionId, peer));
Review Comment:
The reason is that I've actually taken this part from table manager, and I
didn't like this check and thought it would be nice to create some fake
configuration in test that includes all nodes, to be able to create raft node
id. I even thought about it but forgot in final version.
Could you check the current version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
