Re: [PR] Start partitions on corresponding assignments.stable, calculate if missing, cleanup obsolete resources (part 1) [ignite-3]

Tue, 12 Dec 2023 23:52:04 -0800 


sanpwc commented on code in PR #2867:
URL: https://github.com/apache/ignite-3/pull/2867#discussion_r1424969267


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -612,223 +622,191 @@ private CompletableFuture<Void> 
onTableDelete(DropTableEventParameters parameter
     /**
      * Updates or creates partition raft groups and storages.
      *
-     * @param causalityToken Causality token.
      * @param assignmentsFuture Table assignments.
      * @param table Initialized table entity.
      * @return future, which will be completed when the partitions creations 
done.
      */
-    private CompletableFuture<?> createTablePartitionsLocally(
-            long causalityToken,
+    private CompletableFuture<Void> startLocalPartitionsAndUpdateClients(

Review Comment:
   
![NOTSUREIF](https://github.com/apache/ignite-3/assets/18287137/a878a7e2-73d6-4575-9e7f-b831b5f7b475)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to