ygerzhedovich commented on code in PR #2882:
URL: https://github.com/apache/ignite-3/pull/2882#discussion_r1434213534
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -381,7 +386,8 @@ public TableManager(
SchemaSyncService schemaSyncService,
CatalogService catalogService,
HybridTimestampTracker observableTimestampTracker,
- PlacementDriver placementDriver
+ PlacementDriver placementDriver,
+ Supplier<IgniteSql> sql
Review Comment:
the approach say us the we have cyclic dependencies.... It looks bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
