nva commented on code in PR #2882:
URL: https://github.com/apache/ignite-3/pull/2882#discussion_r1434236099
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -381,7 +386,8 @@ public TableManager(
SchemaSyncService schemaSyncService,
CatalogService catalogService,
HybridTimestampTracker observableTimestampTracker,
- PlacementDriver placementDriver
+ PlacementDriver placementDriver,
+ Supplier<IgniteSql> sql
Review Comment:
We already have cyclic dependencies in `ComputeExecutorImpl`.
We can pass `Ignite` instance instead of `Supplier<IgniteSql>`. Will it look
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
