ptupitsyn commented on code in PR #11176: URL: https://github.com/apache/ignite/pull/11176#discussion_r1455469177
########## modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientListenerAsyncResponse.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.odbc; + +import org.apache.ignite.internal.IgniteInternalFuture; +import org.apache.ignite.internal.processors.platform.client.ClientResponse; + +/** + * Client listener async response. + */ +public class ClientListenerAsyncResponse extends ClientResponse { + /** Future for response. */ + private final IgniteInternalFuture<? extends ClientListenerResponse> fut; + + /** + * Constructs async response. + */ + public ClientListenerAsyncResponse(IgniteInternalFuture<? extends ClientListenerResponse> fut) { + super(STATUS_SUCCESS, null); + + this.fut = fut; + } + + /** Future for response. */ + public IgniteInternalFuture<? extends ClientListenerResponse> future() { + return fut; + } + + /** {@inheritDoc} */ + @Override public int status() { + try { + return fut.get().status(); Review Comment: We should not perform a blocking wait on the future, and I think it does not happen in practice. Let's add `fut.isDone` assertion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
