timoninmaxim commented on code in PR #11118:
URL: https://github.com/apache/ignite/pull/11118#discussion_r1465923836
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/CreateDumpFutureTask.java:
##########
@@ -708,7 +714,12 @@ private boolean writtenByIterator(int cache,
KeyCacheObject key, CacheObjectCont
while (writers.get() > 0) // Waiting for all on the fly listeners
to complete.
LockSupport.parkNanos(1_000_000);
- U.closeQuiet(file);
+ try {
+ file.close();
+ }
+ catch (IOException e) {
+ throw new IgniteException(e);
Review Comment:
Do we have a test for that. The test need check that this exception doesn't
affect Ignite node, only the ongoing dump process.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/CreateDumpFutureTask.java:
##########
@@ -708,7 +714,12 @@ private boolean writtenByIterator(int cache,
KeyCacheObject key, CacheObjectCont
while (writers.get() > 0) // Waiting for all on the fly listeners
to complete.
LockSupport.parkNanos(1_000_000);
- U.closeQuiet(file);
+ try {
+ file.close();
+ }
+ catch (IOException e) {
+ throw new IgniteException(e);
Review Comment:
Do we have a test for that? The test need check that this exception doesn't
affect Ignite node, only the ongoing dump process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
